support lowercase first letter properties#186
Open
kddejong wants to merge 1 commit intoaws-cloudformation:masterfrom
Open
support lowercase first letter properties#186kddejong wants to merge 1 commit intoaws-cloudformation:masterfrom
kddejong wants to merge 1 commit intoaws-cloudformation:masterfrom
Conversation
kddejong
force-pushed
the
fix/issue/184
branch
from
9213197 to
33ad849
Compare
Contributor
some desire to not allow properties that start lowercase altogether for consistency |
Contributor
Author
yea I can be okay with that but at this point it is allowed according to the regex. |
brianterry
approved these changes
Sep 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix #184
Description of changes:
Include the json tag value for when the property name starts with a lower case letter.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.