Skip to content

ci: add package install sanity check to build-and-test#590

Merged
Hweinstock merged 1 commit intoaws:mainfrom
Hweinstock:ci/package-test
Mar 20, 2026
Merged

ci: add package install sanity check to build-and-test#590
Hweinstock merged 1 commit intoaws:mainfrom
Hweinstock:ci/package-test

Conversation

@Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Mar 20, 2026

Description

Add a package install sanity check to the build-and-test workflow. After npm pack, the CI now installs the tarball globally and verifies the CLI boots and can scaffold a project. Catches packaging regressions (missing files, broken bin shims, miscategorized deps) before merge.

Related Issue

Closes #591

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe): CI improvement

Testing

The workflow itself is the test — it verifies the packaged tarball installs and runs correctly (agentcore --version, agentcore create).

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions bot added size/xs PR size: XS size/s PR size: S and removed size/xs PR size: XS size/s PR size: S labels Mar 20, 2026
@github-actions github-actions bot added size/xs PR size: XS and removed size/xs PR size: XS labels Mar 20, 2026
@Hweinstock Hweinstock changed the title ci: add package test workflow ci: add package install sanity check to build-and-test Mar 20, 2026
@github-actions github-actions bot added size/xs PR size: XS and removed size/xs PR size: XS labels Mar 20, 2026
@github-actions github-actions bot added size/xs PR size: XS and removed size/xs PR size: XS labels Mar 20, 2026
@github-actions github-actions bot added size/xs PR size: XS and removed size/xs PR size: XS labels Mar 20, 2026
@Hweinstock Hweinstock marked this pull request as ready for review March 20, 2026 20:05
@Hweinstock Hweinstock requested a review from a team March 20, 2026 20:05
@Hweinstock Hweinstock merged commit 06fb886 into aws:main Mar 20, 2026
18 checks passed
@Hweinstock Hweinstock deleted the ci/package-test branch March 20, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: missing coverage of packaging step

3 participants