[v2] Add more granular metrics to benchmarking framework: plugin-load time, static imports time, client creation time.#10292
Open
aemous wants to merge 9 commits into
Open
[v2] Add more granular metrics to benchmarking framework: plugin-load time, static imports time, client creation time.#10292aemous wants to merge 9 commits into
aemous wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
./scripts/performance/run-benchmarks) now emits plugin-load time, static imports time, and client creation time.before-create-ciientandafter-create-clientbefore and after client creation, respectively.create_clidriver, add a new optionalevent_hooksargument to allow callers to provide their own event emitter. This change was needed so the benchmark framework can register against theload_pluginsevent, which is emitted duringcreate_clidriver.--debug-dirparameter inrun-benchmarksscript so that it supports relative paths (previously it only supported absolute paths).Description of tests:
--debug-dirparameter with relative and absolute paths, and verified expected behavior in both cases.Example plugin-load time emission:
{ "name": "cloudwatch.getmetricdata.plugins.import.time", "description": "Total time spent loading all built-in plugins.", "unit": "Seconds", "dimensions": [], "measurements": [ 0.08212709426879883 ] }By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.