Closed
Conversation
ghost
force-pushed
the
input-output-serdes
branch
from
512522b to
f1938b7
Compare
Changes: - We allow input and output serdes on the decorator. This is particularly useful for chained invoke to ensure callees automatically have the correct serialization
ghost
force-pushed
the
input-output-serdes
branch
from
f1938b7 to
e59accd
Compare
ghost
marked this pull request as ready for review
ghost
changed the title
ghost
closed this
ghost
reopened this
yaythomas
requested changes
Nov 21, 2025
leandrodamascena
requested changes
Nov 21, 2025
Contributor
leandrodamascena
left a comment
leandrodamascena
left a comment
There was a problem hiding this comment.
I think we can improve it by removing nonlocal variable.. If you don't like the idea of defining serdes=output_serdes or JsonSerDes(), because it's not clear - I think it is -, you can set variables like _input_serder = input_serders or JsonSerDes(), and then use those variables.
ghost
force-pushed
the
input-output-serdes
branch
from
7fe59ad to
94e13d9
Compare
ghost
commented
Nov 21, 2025
leandrodamascena
approved these changes
Nov 21, 2025
Member
|
on hold, pending alignment with JS/TS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.