fix: skip Python binary validation when pip is not used (#678)#830
Merged
reedham-aws merged 2 commits intoaws:developfrom Feb 3, 2026
Merged
Conversation
When no requirements.txt exists or download_dependencies=False, the workflow only copies files and doesn't run pip. In these cases, skip PythonRuntimeValidator and use the base RuntimeValidator instead. This allows builds to succeed even when the target Python runtime isn't installed locally, as long as no dependencies need to be installed.
github-actions
bot
added
pr/external
stage/needs-triage
reedham-aws
approved these changes
Jan 27, 2026
Contributor
reedham-aws
left a comment
reedham-aws
left a comment
There was a problem hiding this comment.
These changes individually look good to me (and thus I'm approving). I do have a question about whether this pattern should apply to other workflows. For example, should the Ruby builder need ruby installed? It's fine by me if we merge this and then create an issue to track the remaining ones, but please correct me if this is a pip only issue.
Contributor
Author
|
Yeah I thought about it when I was creating this PR, I think meta across all makes sense. we should address holistically too. |
vicheey
approved these changes
Feb 2, 2026
Contributor
|
I created an issue for the remaining work for this in #831, but will merge this CR now. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no requirements.txt exists or download_dependencies=False, the workflow only copies files and doesn't run pip. In these cases, skip PythonRuntimeValidator and use the base RuntimeValidator instead.
This allows builds to succeed even when the target Python runtime isn't installed locally, as long as no dependencies need to be installed.
Issue #, if available:
#678
Description of changes
Determine if pip is required for the workflow and only then validate the runtime.
Description of how you validated changes
Unit tests and integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.