Merged
Conversation
Adding CRTProfileCredentialsProvider for CRT-based profile credential
…ofile-credentials-provider
…ofile-credentials-provider
…le provider to the default chain
merge branch 'main' of https://github.com/aws/aws-sdk-cpp into crt-profile-credentials-provider
…ofile-credentials-provider
… to ProfileCredentialsProvider
…ofile-credentials-provider
…ider from the default chain, also enabling the ProcessCredentials on ProfileCredentialsProvider
sbiscigl
reviewed
Feb 12, 2026
| * refreshRateMs as the frequency at which the file is reparsed in milliseconds. Defaults to 5 minutes. | ||
| */ | ||
| ProfileCredentialsProvider(const char* profile, long refreshRateMs = REFRESH_THRESHOLD); | ||
| ProfileCredentialsProvider(const char* profile); |
Contributor
There was a problem hiding this comment.
cant remove this from the public facing interface -- thats a breakign change, it just wont be passed down the impl
| */ | ||
| static Aws::String GetProfileDirectory(); | ||
|
|
||
| protected: |
Contributor
There was a problem hiding this comment.
cant remove this from the interface thats a breaking change, you can have it but it must do nothing
| ReaderLockGuard guard(m_reloadLock); | ||
| if (!IsTimeToRefresh(m_loadFrequencyMs)) { | ||
| return; | ||
| class ProfileCredentialsProvider::ProfileCredentialsProviderImp : public CrtCredentialsProvider { |
Contributor
There was a problem hiding this comment.
public CrtCredentialsProvider
chefs kiss
| :CrtCredentialsProvider( | ||
| [profile]()-> std::shared_ptr<ICredentialsProvider> { | ||
| CredentialsProviderProfileConfig config; | ||
| if (profile && profile[0] !='\0') { |
Contributor
There was a problem hiding this comment.
do we need this validation?
| CredentialsProviderProfileConfig config; | ||
| return CredentialsProvider::CreateCredentialsProviderProfile(config); | ||
| }, | ||
| std::chrono::milliseconds(5000), |
pulimsr
force-pushed
the
crt-profile-credentials-provider
branch
2 times, most recently
from
44b26f3 to
1be720c
Compare
pulimsr
force-pushed
the
crt-profile-credentials-provider
branch
12 times, most recently
from
202cd92 to
6e326d4
Compare
pulimsr
force-pushed
the
crt-profile-credentials-provider
branch
from
6e326d4 to
10024fa
Compare
…ofile-credentials-provider
…/aws/aws-sdk-cpp into crt-profile-credentials-provider
…ntialTrackingTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing the CRT's profile provider and removing the process provider from the default chain, also enabling the ProcessCredentials on ProfileCredentialsProvider
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.