SnsMessageManager Impl#6804
Conversation
Provides an implementation of the SnsMessageManager. This mostly just ties all the other classes implemented in previous PRs related to the message manager.
| /** | ||
| * Utility to load the default HTTP client factory and create an instance of {@link SdkHttpClient}. | ||
| */ | ||
| @SdkInternalApi |
There was a problem hiding this comment.
We'll need to discuss this change, but hopefully not contentious. I didn't want to move it out of the internal package as that would be a breaking change.
There was a problem hiding this comment.
Change discussed with the team, and there are no concerns wit this. 3415f9b allowlists this so the arch tests pass.
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>apache5-client</artifactId> |
There was a problem hiding this comment.
This more or less means we should block this until #6732 is merged
...c/main/java/software/amazon/awssdk/messagemanager/sns/internal/DefaultSnsMessageManager.java
Show resolved
Hide resolved
...est/java/software/amazon/awssdk/messagemanager/sns/internal/CertificateUrlValidatorTest.java
Show resolved
Hide resolved
...c/main/java/software/amazon/awssdk/messagemanager/sns/internal/DefaultSnsMessageManager.java
Show resolved
Hide resolved
|
dagnir
merged commit cb9930c
into
feature/master/sns-message-manager
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
2 participants
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License