Skip to content

(bug fix): Skipping sagemaker extension activation for non sagemaker environments #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aakashmandavilli96 merged 2 commits into from
Mar 13, 2026
Merged

(bug fix): Skipping sagemaker extension activation for non sagemaker environments #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
552bfb4
(bug fix): Skipping sagemaker extension activation for non sagemaker …
aws-srmanda-28 Mar 13, 2026
f1825ba
fix: Remove TODO comment from sagemaker extension activation
aws-srmanda-28 Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions patches/sagemaker/sagemaker-extension.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Index: code-editor-src/extensions/sagemaker-extension/src/extension.ts
===================================================================
--- /dev/null
+++ code-editor-src/extensions/sagemaker-extension/src/extension.ts
@@ -0,0 +1,205 @@
@@ -0,0 +1,211 @@
+import * as vscode from 'vscode';
+import * as fs from 'fs';
+import { SessionWarning } from "./sessionWarning";
Expand Down Expand Up @@ -179,7 +179,13 @@ Index: code-editor-src/extensions/sagemaker-extension/src/extension.ts
+
+export function activate(context: vscode.ExtensionContext) {
+
+ // TODO: log activation of extension
+ // this extension will only activate within a sagemaker app
+ const isSageMakerApp = !!process.env?.SAGEMAKER_APP_TYPE_LOWERCASE;
+ if (!isSageMakerApp) {
+ console.log('Skipping activation of Sagemaker Extension...');
+ return;
+ }
+
+ console.log('Activating Sagemaker Extension...');
+
+ // execute the get cookie command and save the data to cookies
Expand Down
5 changes: 4 additions & 1 deletion patches/sagemaker/sagemaker-extensions-sync.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ Index: code-editor-src/extensions/sagemaker-extensions-sync/src/extension.ts
===================================================================
--- /dev/null
+++ code-editor-src/extensions/sagemaker-extensions-sync/src/extension.ts
@@ -0,0 +1,100 @@
@@ -0,0 +1,103 @@
+import * as process from "process";
+import * as vscode from 'vscode';
+
Expand All @@ -163,9 +163,12 @@ Index: code-editor-src/extensions/sagemaker-extensions-sync/src/extension.ts
+ // this extension will only activate within a sagemaker app
+ const isSageMakerApp = !!process.env?.SAGEMAKER_APP_TYPE_LOWERCASE;
+ if (!isSageMakerApp) {
+ console.log('Skipping activation of Sagemaker Extension Sync...');
+ return;
+ }
+
+ console.log('Activating Sagemaker Extension Sync...');
+
+ // get installed extensions. this could be different from pvExtensions b/c vscode sometimes doesn't delete the assets
+ // for an old extension when uninstalling or changing versions
+ const installedExtensions = new Set(await getInstalledExtensions());
Expand Down
Loading