fix(ci): pin pnpm@9.15.9 and refresh lockfile with security overrides#564
Open
isaquebock wants to merge 4 commits into
Open
fix(ci): pin pnpm@9.15.9 and refresh lockfile with security overrides#564isaquebock wants to merge 4 commits into
isaquebock wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
ERR_PNPM_LOCKFILE_CONFIG_MISMATCHin thePublish @aziontech/theme to NPMworkflow (and any other CI job runningpnpm install --frozen-lockfile).Root cause
pnpm/action-setup@v4withversion: 9), which readspnpm.overridesfrompackage.json.pnpm.overrides(it only readsoverridesfrompnpm-workspace.yaml).overrides:section. CI's pnpm 9 saw 13 overrides inpackage.jsonvs 0 in the lockfile → frozen install rejected the divergence.Changes
package.json"packageManager": "pnpm@9.15.9"so Corepack pins every environment (CI + local) to the same pnpm version."overrides"block. pnpm doesn't read it — onlypnpm.overridesmatters on pnpm 9. The npm-style top-level field was noise and made the mismatch harder to diagnose.pnpm-lock.yamloverrides:section at the top (13 entries, matchingpnpm.overrides) and applies them to transitive resolutions for the first time. Lockfile shrunk ~140 lines from deduping that overrides made possible.packages/theme/README.mdTest plan
pnpm install --frozen-lockfilewith pnpm 9.15.9 →Lockfile is up to date(simulates the CI step that was failing).overrides:block is present inpnpm-lock.yaml(line 7).Publish @aziontech/theme to NPMworkflow won't run here — it'spaths: packages/theme/**onmain— butgovernanceandpackage-webkitinstall paths exercise the samepnpm install --frozen-lockfile).maintouchingpackages/theme/**completes the theme publish job.Notes for reviewers
pnpm.overridesfrompackage.jsonintopnpm-workspace.yamland bumppackageManageraccordingly. Out of scope for this PR.