Fix validate-renovate workflow path drift (.json5 → .json)#351
Open
adsurg wants to merge 2 commits into
Open
Conversation
Signed-off-by: Adam Surgenor <adam@surgenor.me>
…orkflow Signed-off-by: Adam Surgenor <adam@surgenor.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
validate-renovate.ymlworkflow is wired to a filename that doesn't exist in this repo, so the Renovate config has effectively been unvalidated on PRs.Two mismatches in
.github/workflows/validate-renovate.yml:paths:filter targeted.github/renovate.json5, but the on-disk config is.github/renovate.json. PRs touching the config never triggered the workflow.pattern: '*.json5', which matches no files in the repo.Both now point at
.github/renovate.json, the actual config filename.Why this direction (
.jsonrather than renaming to.json5).json5is Renovate's preferred format, but the existingrenovate.jsonuses no JSON5-only syntax (no comments, no trailing commas, no unquoted keys). Renaming would be a stylistic migration with no functional benefit and a larger diff. The smaller, safer fix is to align the workflow with the file that already exists.Verifying it runs
Touched
.github/renovate.jsonwith a no-op"description"field so this PR exercises thepaths:filter and you can see the workflow trigger and pass green. The field is semantically inert for Renovate; it just documents that the file is validated on PR.Scope
extends, samepackageRules.Context
Came out of a project-level repo review rather than a GitHub issue. Companion small-fix PR to
backstage/charts#326 (the dual-stack Helm-doc README fix), part of the same review pass.