Conversation
added 2 commits
January 12, 2026 12:24
…or versions and adding and example to /examples/plugin/vite
Collaborator
|
Shouldn't we add this an example to the example repo? |
konraddysput
approved these changes
Jan 12, 2026
examples/plugin/vite/package.json
Outdated
| "typescript": "^5.0.4", | ||
| "vite": "7.1.5" | ||
| } | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
end of file character - can we add an enter?
Contributor
Author
|
@konraddysput we didn't have any examples for the plugins, only sdks, so I created /examples/plugin. I can move it under /examples/sdk/ if you'd prefer though |
Collaborator
It does the same what our example do so maybe its just better to use an sdk example? Its up to you guys- its just an suggestion. |
GT1990
approved these changes
Jan 13, 2026
Contributor
Author
|
I feel you. I do like that it's an example that's vite specific though. I'll probably keep it if you don't mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the rollup and vite plugins to be compatible with the latest major versions as well as added an example in /examples/plugin/vite