-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Feat/crosschain savings #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…hain-lp-sicx-baln
…n verified on token transfer test
# Conflicts: # core-contracts/Dex/src/main/java/network/balanced/score/core/dex/AbstractDex.java # core-contracts/Router/src/main/java/network/balanced/score/core/router/RouterImpl.java # core-contracts/Router/src/test/java/network/balanced/score/core/router/RouterTest.java # score-lib/src/main/java/network/balanced/score/lib/interfaces/Dex.java # score-lib/src/main/java/network/balanced/score/lib/utils/Versions.java
# Conflicts: # core-contracts/Dex/src/main/java/network/balanced/score/core/dex/AbstractDex.java # core-contracts/Router/src/main/java/network/balanced/score/core/router/RouterImpl.java # core-contracts/Router/src/test/java/network/balanced/score/core/router/RouterTest.java # score-lib/src/main/java/network/balanced/score/lib/interfaces/Dex.java # score-lib/src/main/java/network/balanced/score/lib/utils/Versions.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
============================================
- Coverage 73.21% 73.03% -0.19%
- Complexity 1626 1634 +8
============================================
Files 120 120
Lines 7759 7814 +55
Branches 936 941 +5
============================================
+ Hits 5681 5707 +26
- Misses 1671 1701 +30
+ Partials 407 406 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AntonAndell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most code could need some formatting, otherwise just a few small comments
core-contracts/Savings/src/main/java/network/balanced/score/core/savings/SavingsImpl.java
Show resolved
Hide resolved
core-contracts/Savings/src/main/java/network/balanced/score/core/savings/SavingsImpl.java
Outdated
Show resolved
Hide resolved
score-lib/src/main/java/network/balanced/score/lib/utils/Versions.java
Outdated
Show resolved
Hide resolved
core-contracts/Router/src/main/java/network/balanced/score/core/router/RouterImpl.java
Show resolved
Hide resolved
core-contracts/Router/src/main/java/network/balanced/score/core/router/RouterImpl.java
Outdated
Show resolved
Hide resolved
# Conflicts: # score-lib/src/main/java/network/balanced/score/lib/utils/Versions.java
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: