Skip to content

Conversation

@TRSSMG
Copy link
Collaborator

@TRSSMG TRSSMG commented Nov 29, 2024

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

sagars added 30 commits October 2, 2024 11:33
# Conflicts:
#	core-contracts/Dex/src/main/java/network/balanced/score/core/dex/AbstractDex.java
#	core-contracts/Router/src/main/java/network/balanced/score/core/router/RouterImpl.java
#	core-contracts/Router/src/test/java/network/balanced/score/core/router/RouterTest.java
#	score-lib/src/main/java/network/balanced/score/lib/interfaces/Dex.java
#	score-lib/src/main/java/network/balanced/score/lib/utils/Versions.java
# Conflicts:
#	core-contracts/Dex/src/main/java/network/balanced/score/core/dex/AbstractDex.java
#	core-contracts/Router/src/main/java/network/balanced/score/core/router/RouterImpl.java
#	core-contracts/Router/src/test/java/network/balanced/score/core/router/RouterTest.java
#	score-lib/src/main/java/network/balanced/score/lib/interfaces/Dex.java
#	score-lib/src/main/java/network/balanced/score/lib/utils/Versions.java
@TRSSMG TRSSMG requested a review from AntonAndell November 29, 2024 09:37
@TRSSMG TRSSMG self-assigned this Nov 29, 2024
@TRSSMG TRSSMG added the enhancement New feature or request label Nov 29, 2024
@codecov
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 53.52113% with 33 lines in your changes missing coverage. Please review.

Project coverage is 73.03%. Comparing base (6ce124f) to head (3d864ec).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
.../network/balanced/score/lib/structs/RouteData.java 0.00% 31 Missing ⚠️
...twork/balanced/score/core/savings/SavingsImpl.java 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #467      +/-   ##
============================================
- Coverage     73.21%   73.03%   -0.19%     
- Complexity     1626     1634       +8     
============================================
  Files           120      120              
  Lines          7759     7814      +55     
  Branches        936      941       +5     
============================================
+ Hits           5681     5707      +26     
- Misses         1671     1701      +30     
+ Partials        407      406       -1     
Flag Coverage Δ
java 73.03% <53.52%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TRSSMG TRSSMG changed the title Feat/crosschain savings feat: Feat/crosschain savings Nov 29, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 8, 2024
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most code could need some formatting, otherwise just a few small comments

@AntonAndell AntonAndell merged commit 6cc3af0 into main Feb 3, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants