Skip to content

fix: Use from in govtransfer #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AntonAndell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Use from in govtransfer #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions score-lib/src/main/java/network/balanced/score/lib/utils/Versions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
public class Versions {
public final static String BALN = "v1.1.2";
public final static String DIVIDENDS = "v1.0.0";
public final static String LOANS = "v1.2.3";
public final static String LOANS = "v1.2.4";
public final static String RESERVE = "v1.0.0";
public final static String SICX = "v1.1.1";
public final static String SICX = "v1.1.2";
public final static String STAKING = "v1.0.1";
public final static String WORKERTOKEN = "v1.0.0";
public final static String BNUSD = "v1.1.1";
Expand Down
9 changes: 7 additions & 2 deletions token-contracts/Sicx/src/main/java/network/balanced/score/tokens/sicx/SicxImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,14 @@
public void govTransfer(Address _from, Address _to, BigInteger _value, @Optional byte[] _data) {
onlyOwner();
if (!_to.equals(stakingAddress.get())) {
Context.call(stakingAddress.get(), "transferUpdateDelegations", Context.getCaller(), _to, _value);
Context.call(stakingAddress.get(), "transferUpdateDelegations",_from, _to, _value);

Check warning on line 114 in token-contracts/Sicx/src/main/java/network/balanced/score/tokens/sicx/SicxImpl.java

View check run for this annotation

Codecov / codecov/patch

token-contracts/Sicx/src/main/java/network/balanced/score/tokens/sicx/SicxImpl.java#L114 

Added line #L114 was not covered by tests
}
super.transfer(_to, _value, _data);

super._transfer(

Check warning on line 117 in token-contracts/Sicx/src/main/java/network/balanced/score/tokens/sicx/SicxImpl.java

View check run for this annotation

Codecov / codecov/patch

token-contracts/Sicx/src/main/java/network/balanced/score/tokens/sicx/SicxImpl.java#L117 

Added line #L117 was not covered by tests
new NetworkAddress(super.NATIVE_NID, _from),
new NetworkAddress(super.NATIVE_NID, _to),
_value,
_data);
}

@Override
Expand Down
Loading