Skip to content

feat: add logic to remove extra added chains #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AntonAndell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add logic to remove extra added chains #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions score-lib/src/main/java/network/balanced/score/lib/tokens/HubTokenImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import network.balanced.score.lib.interfaces.tokens.HubTokenXCall;
import network.balanced.score.lib.utils.BalancedAddressManager;
import network.balanced.score.lib.utils.XCallUtils;
import network.balanced.score.lib.utils.ArrayDBUtils;
import score.Address;
import score.ArrayDB;
import score.Context;
Expand Down Expand Up @@ -72,6 +73,14 @@
return chains;
}


@External
public void removeChain(String _networkAddress) {
onlyOwner();
ArrayDBUtils.removeFromArraydb(NetworkAddress.parse(_networkAddress), connectedChains);
}

Check warning on line 81 in score-lib/src/main/java/network/balanced/score/lib/tokens/HubTokenImpl.java

View check run for this annotation

Codecov / codecov/patch

score-lib/src/main/java/network/balanced/score/lib/tokens/HubTokenImpl.java#L79-L81 

Added lines #L79 - L81 were not covered by tests


@External
public void addChain(String _networkAddress, BigInteger limit) {
onlyOwner();
Expand Down
2 changes: 1 addition & 1 deletion score-lib/src/main/java/network/balanced/score/lib/utils/Versions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public class Versions {
public final static String SICX = "v1.1.1";
public final static String STAKING = "v1.0.1";
public final static String WORKERTOKEN = "v1.0.0";
public final static String BNUSD = "v1.1.1";
public final static String BNUSD = "v1.1.2";
public final static String FEEHANDLER = "v1.0.1";
public final static String REWARDS = "v1.2.4";
public final static String STABILITY = "v1.1.1";
Expand Down
5 changes: 5 additions & 0 deletions ...Dollar/src/main/java/network/balanced/score/tokens/balanceddollar/BalancedDollarImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
import network.balanced.score.lib.utils.BalancedAddressManager;
import network.balanced.score.lib.utils.Names;
import network.balanced.score.lib.utils.Versions;
import network.balanced.score.lib.utils.ArrayDBUtils;

import score.Address;
import score.Context;
import score.VarDB;
Expand Down Expand Up @@ -54,6 +56,9 @@
}

NATIVE_NID = Context.call(String.class, BalancedAddressManager.getXCall(), "getNetworkId");
if (connectedChains.size() > 0) {
ArrayDBUtils.removeFromArraydb(NetworkAddress.parse("stellar/CAKU2J5T4TOMFATA56XRDZMQHNBFIOQW3JDZQNQBLNLV7LEWYTNYU6VX"), connectedChains);

Check warning on line 60 in token-contracts/BalancedDollar/src/main/java/network/balanced/score/tokens/balanceddollar/BalancedDollarImpl.java

View check run for this annotation

Codecov / codecov/patch

token-contracts/BalancedDollar/src/main/java/network/balanced/score/tokens/balanceddollar/BalancedDollarImpl.java#L60 

Added line #L60 was not covered by tests
}

if (this.currentVersion.getOrDefault("").equals(Versions.BNUSD)) {
Context.revert("Can't Update same version of code");
Expand Down
Loading