fix: typo and broken anchor in legal docs#1450
Open
memosr wants to merge 2 commits into
Open
Conversation
Updates 8 instances of http:// URLs to https:// across 5 documentation files to prevent mixed-content warnings and ensure secure connections to external and internal Base resources. Files updated: - docs/terms-of-service.mdx (Privacy Policy link) - docs/base-account/basenames/basenames-faq.mdx (3 links) - docs/apps/builder-codes/app-developers.mdx (2 base.dev links) - docs/base-account/more/troubleshooting/usage-details/wallet-library-support.mdx (ThirdWeb) - docs/get-started/base-mentorship-program.mdx (X/Twitter link)
- Fix 'is is' duplicate word in derivation.mdx (Holocene upgrade spec) - Fix broken Google Docs anchor (#bookmark=id...) in terms-of-service.mdx by adding proper HTML anchor for 'APPENDIX 1: ARBITRATION AGREEMENT' section The terms-of-service link previously pointed to a Google Docs internal bookmark ID that has no equivalent in the rendered Markdown, causing the in-page navigation to fail.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two unrelated but small issues in documentation:
Changes
1.
docs/base-chain/specs/upgrades/holocene/derivation.mdx(line 230)2.
docs/terms-of-service.mdxThe intro section links to
#bookmark=id.9q2273ceqaa4— a Google Docs internal bookmark ID copied during migration. The target section "APPENDIX 1: ARBITRATION AGREEMENT" is bold text without an HTML anchor, so this link 404s.Added an HTML anchor before the appendix heading:
+ <a id="appendix-1"></a> **APPENDIX 1: ARBITRATION AGREEMENT**Why