fix(snippets): fixed existence-check snippets

[alexanderwoehler]

Snippet-Fix

As of now, the "if-defined" and "if-not-defined" snippets are missing ; then after the condition, which results in broken snippets (see below)

$ cat test.sh
# if-defined
if [[ -n "${variable+x}" ]]
    command ...
fi

# if-not-defined
if [[ -z "${variable+x}" ]]
    command ...
if

$ shellcheck test.sh

In test.sh line 2:
if [[ -n "${variable+x}" ]]
^-- SC1049 (error): Did you forget the 'then' for this 'if'?
^-- SC1073 (error): Couldn't parse this if expression. Fix to allow more checks.


In test.sh line 4:
fi
^-- SC1050 (error): Expected 'then'.
  ^-- SC1072 (error): Unexpected keyword/token. Fix any mentioned problems and try again.

For more information:
  https://www.shellcheck.net/wiki/SC1049 -- Did you forget the 'then' for thi...
  https://www.shellcheck.net/wiki/SC1050 -- Expected 'then'.
  https://www.shellcheck.net/wiki/SC1072 -- Unexpected keyword/token. Fix any...

[skovhus]

Thanks. Can you run pnpm lint?

[alexanderwoehler]

done

$ pnpm lint

> @ lint .../bash-language-server
> pnpm lint:bail --fix


> @ lint:bail .../bash-language-server
> eslint . --ext js,ts,tsx --cache "--fix"

Fixed a typo and pnpm lint reformatted the if-defined and if-not-defined snippets. I "fixupped" these formatting changes together with my initial fix, I hope thats fine :)

[Shane-XB-Qian]

It would be nice to have a snippet for argument parsing using geopts. There already is a PR (see #937) which covers this, but there has not been any activity for months and I do not know why.

please check/refer #897
// you can either help to refine this had been merged snips here,
// or if you were vimer, there local snipmate etc plugins as well, or vsc i guess there were similar ones too.

[Shane-XB-Qian]

It would be nice to have a snippet for argument parsing using geopts. There already is a PR (see #937) which covers this, but there has not been any activity for months and I do not know why.

please check/refer #897
// you can either help to refine this had been merged snips here,
// or if you were vimer, there local snipmate etc plugins as well, or vsc i guess there were similar ones too.

[alexanderwoehler]

@Shane-XB-Qian i removed the new snippet for getopts so this PR only includes the bugfixes for the two snippets "if-defined" and "if-not-defined"

[Shane-XB-Qian]

um... i was just giving you the background information, if you thought your version of 'getopts' was better then i supposed it is ok to add it still, but just saying there other alternatives for snips, and of course to fix the current had merged is good.