Feature/allow different delimiters for sed and prettify labels#913
Closed
EmilyGraceSeville7cf wants to merge 5 commits intobash-lsp:mainfrom
Closed
Conversation
added 5 commits
July 17, 2023 02:33
…github.com/EmilySeville7cfg/bash-language-server into feature/allow-different-delimiters-for-sed
Collaborator
|
Thanks!
Curious what the reason behind this change. Is that more standard? |
Contributor
Author
This change reflects this comment. Actually there is no standard here AFAIK. You can meet spaces in labels too. I am thinking about replacing |
Contributor
|
I am thinking about replacing `-` with spaces. But I don't know whether Vim/Emacs will be okay with such snippets. @Shane-XB-Qian, do you know anything about this? Is it fine to have spaces for snippets used in Vim/Emacs?
i preferred `_` (underscore) (though `-` maybe workable) IF snips have to store in server.
…--
shane.xb.qian
|
Contributor
Author
|
This PR is closed in favor to #923. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|delimiter for sed commands-instead of:in labels