Skip to content

fix(pypi): allow index probes to fail on root path #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
udaya2899 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

fix(pypi): allow index probes to fail on root path #3770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions python/private/pypi/simpleapi_download.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ def _get_dist_urls(ctx, *, default_index, index_urls, index_url_overrides, sourc
parse_index = True,
versions = {pkg: None for pkg in sources},
block = block,
allow_fail = True,
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Adding allow_fail = True here will cause existing tests to fail. The mock read_simpleapi functions in tests/pypi/simpleapi_download/simpleapi_download_tests.bzl (specifically in _test_simple and _test_index_overrides) do not accept the allow_fail keyword argument.

You should update those mock signatures to include **kwargs or explicitly accept allow_fail to maintain compatibility with this change.

Copy link
Copy Markdown
Author

@udaya2899 udaya2899 May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a better solution if it exists, and if the fix is not obvious, or simple, I am happy with closing this (tbh low effort) PR. I created this because this worked for our use case.

Copy link
Copy Markdown
Collaborator

@aignas aignas May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another fix could be to just not call the index at all if there is only one index url given.

**kwargs
)
if hasattr(download, "wait"):
Expand All @@ -170,6 +171,8 @@ def _get_dist_urls(ctx, *, default_index, index_urls, index_url_overrides, sourc

found_on_index = {}
for index_url, result in results.items():
if not result.success:
continue
for pkg in sources:
if pkg in found_on_index:
# We have already found the package, skip searching for it in
Expand Down