Support MSVC with rule-based toolchain #561
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebzulawski
requested review from
armandomontanez,
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
calebzulawski
force-pushed
the
msvc
branch
4 times, most recently
from
3026007 to
de3d08d
Compare
calebzulawski
force-pushed
the
msvc
branch
2 times, most recently
from
3a3bcfd to
a16e39b
Compare
Collaborator
|
Wow, this is AWESOME! I'd like to help get this landed in the next week. At first glance this looks pretty good, need to spend a bit more time to look through the rest. |
Contributor
|
We're also very interested as part of https://github.com/cerisier/toolchains_llvm_bootstrapped ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #436, but contains the full MSVC implementation.