Add linker dir to bin_search_flags for lld/gold for non-Clang compilers #571
+50
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang allows a full path to be passed to -fuse-ld=. However, GCC (and others?) don't allow this. If gold or lld is selected, the linker is not on a standard path (e.g. Gentoo, which allows multiple versions of LLVM to be installed in /usr/lib/llvm/<major>/) and --incompatible_strict_action_env is enabled, GCC won't know where the linker is located and fail to find the linker. Now we always return the full linker path, and pass -fuse-ld= based on the compiler identity. Fixes bazelbuild/bazel#26527.
sin-ack
requested review from
armandomontanez,
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
Author
|
Build failures appear to be docs related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang allows a full path to be passed to
-fuse-ld=. However, GCC (and others?) don't allow this. If gold or lld is selected, the linker is not on a standard path (e.g. Gentoo, which allows multiple versions of LLVM to be installed in/usr/lib/llvm/<major>/) and--incompatible_strict_action_envis enabled, GCC won't know where the linker is located and fail to find the linker.Now we always return the full linker path, and pass
-fuse-ld=based on the compiler identity.Fixes bazelbuild/bazel#26527.