Fix empty flags errors #575
Open
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
requested review from
armandomontanez,
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
If the user passed empty flags this failed Fixes bazelbuild#404
keith
force-pushed
the
ks/fix-empty-flags-errors
branch
from
ef9fde0 to
a62a83a
Compare
armandomontanez
approved these changes
Jan 29, 2026
armandomontanez
added
category: toolchain rules
P2
hvadehra
reviewed
Jan 30, 2026
Member
hvadehra
left a comment
hvadehra
left a comment
There was a problem hiding this comment.
Any chance we can add a test for this? Perhaps along the lines of the ones in https://github.com/bazelbuild/rules_cc/tree/main/tests/rule_based_toolchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user passed empty flags this failed
Fixes #404