Account for other sync events from the TimeSyncController#109
Open
ryanmccartney wants to merge 1 commit intosmp-v4.7from
Open
Account for other sync events from the TimeSyncController#109ryanmccartney wants to merge 1 commit intosmp-v4.7from
TimeSyncController#109ryanmccartney wants to merge 1 commit intosmp-v4.7from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving some useful debugging code here that can be added to the
XHRLoaderat the top of therequestfunction (Line 60). That help demonstrate whether the timeline has actually moved.Before the change
With
liveDelayset to 12s andartificialTimeOffsetToApply-5000ms.Note, only appears to happen on the first load of the player. Subsequent “loads” of the reference player results in the expected behaviour. Looks like this could be a race condition on which
UPDATE_TIME_SYNC_OFFSETtriggers first.After the change
With
liveDelayset to 12s andartificialTimeOffsetToApply-5000ms.