Worked on comments improvements such as disable comment icon when com…#276
Open
shahidajmeri786 wants to merge 2 commits into0.5from
Open
Worked on comments improvements such as disable comment icon when com…#276shahidajmeri786 wants to merge 2 commits into0.5from
shahidajmeri786 wants to merge 2 commits into0.5from
Conversation
…ment is disabled in wordpress system and display the comment author url on comment detail view
Collaborator
|
@brentjett this PR covers #256 and #264 but after seeing the work you're doing in the comments app, I'm wondering if we should hold off for now. Have a look at the PR and let me know what you think. |
Collaborator
|
@shahidajmeri786 Brent ended up doing a lot of work in 0.5 on the comments list. Check it out, it looks really nice! Anyhow, we're getting some nasty conflicts here now. Would you mind creating a new branch off 0.5 and reimplementing these changes there? Once that's done, we can ditch this branch/PR. |
Contributor
Author
|
I took a pull of master and created a new branch and did changes into it. #287 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worked on comments improvements such as disable comment icon when a comment is disabled in WordPress system and display the comment author URL on the comment detail view