Fix replace command callback signature#6700
Open
Tsuizxgo wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6700 +/- ##
==========================================
+ Coverage 72.59% 72.61% +0.01%
==========================================
Files 162 162
Lines 20811 20811
Branches 3293 3293
==========================================
+ Hits 15107 15111 +4
+ Misses 4980 4975 -5
- Partials 724 725 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6260.
The
replaceplugin assignsReplacePlugin.rundirectly as thereplacecommand callback. Beets command callbacks are invoked with(lib, opts, args), butReplacePlugin.runonly accepted(lib, args), so invoking the command raised:This change updates the callback signature to accept the options argument and adds regression coverage for invoking
beet replacethrough the command runner.To Do
Documentation.This is a bug fix for an existing command.docs/changelog.rst.Tests