Skip to content

chore: improve beets maintenance path#6712

Open
lphuc2250gma wants to merge 1 commit into
beetbox:masterfrom
lphuc2250gma:maint/20260606032539
Open

chore: improve beets maintenance path#6712
lphuc2250gma wants to merge 1 commit into
beetbox:masterfrom
lphuc2250gma:maint/20260606032539

Conversation

@lphuc2250gma
Copy link
Copy Markdown

Summary:

  • Add or tighten focused edge-case tests or type assertions in test/test_util.py, test/test_files.py related to Python typing, tests, CLI ergonomics, observability; avoid docs-only changes and broad refactors.
  • Keep the change narrow so it is straightforward to review.

Notes:

  • I kept this scoped to the relevant implementation and tests.

@lphuc2250gma lphuc2250gma requested a review from a team as a code owner June 6, 2026 03:28
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 6, 2026

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.58%. Comparing base (8152e43) to head (ca71da5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6712   +/-   ##
=======================================
  Coverage   75.57%   75.58%           
=======================================
  Files         162      162           
  Lines       20810    20810           
  Branches     3294     3294           
=======================================
+ Hits        15727    15729    +2     
+ Misses       4307     4306    -1     
+ Partials      776      775    -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread test/test_files.py
a = ["a", "b", "c"]
assert util.components(p) == a

def test_ancestry_works_on_empty_string(self):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind refactoring these tests to use pytest.mark.parametrize?

Comment thread uv.lock
@@ -0,0 +1,3 @@
version = 1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this one for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants