Open
Conversation
- add get_completion_domain in the quoted synopsis - change SCHED-ENV to use get_start_scheduler instead of get_scheduler - remove the write_env use from on (should have been done by P3826r3) - change on to use get_start_scheduler instead of get_scheduler - update the sentence for make-sender(affine_on...) - change affine_on to use continues_on instead of schedule_from - update the reference paragraph numbers in [exec.run.loop.types]
dietmarkuehl
requested review from
bretbrownjr,
steve-downey and
wusatosi
as code owners
There was a problem hiding this comment.
Pull request overview
Rebases the P3941 “Scheduler Affinity” wording on P3826r3’s customization changes, updating the proposed standard wording to reflect newer CPOs and revised algorithm definitions.
Changes:
- Adds
get_completion_domainto the quotedstd::executionsynopsis. - Updates
SCHED-ENVandonwording to useget_start_scheduler(and removeswrite_envusage fromon’s exposition). - Revises
affine_onwording to usecontinues_oninstead ofschedule_from, and updates referenced paragraph numbers inexec.run.loop.types.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_completion_domainin the quoted synopsisSCHED-ENVto useget_start_schedulerinstead ofget_schedulerwrite_envuse from on (should have been done by P3826r3)onto useget_start_schedulerinstead ofget_schedulermake-sender(affine_on...)affine_onto usecontinues_oninstead ofschedule_from