Skip to content

Truncate recommend() result to caller's N when filter_items is set (#736) #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cyberfilo wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

Truncate recommend() result to caller's N when filter_items is set (#736) #757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion implicit/nearest_neighbours.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@ def recommend(
if filter_items is not None and items is not None:
raise ValueError("Can't specify both filter_items and items")

# Preserve the caller-requested result count: when filter_items is
# set we over-fetch by len(filter_items) so that the post-filter
# slice still has enough rows to satisfy N, but the final result
# must be truncated to the originally-requested N (not the
# inflated value). See https://github.com/benfred/implicit/issues/736
requested_n = N
if filter_items is not None:
N += len(filter_items)
elif items is not None:
Expand All @@ -91,7 +97,7 @@ def recommend(

if filter_items is not None:
mask = np.isin(ids, filter_items, invert=True)
ids, scores = ids[mask][:N], scores[mask][:N]
ids, scores = ids[mask][:requested_n], scores[mask][:requested_n]

elif items is not None:
mask = np.isin(ids, items)
Expand Down