Conversation
… focused Replace `border: none` with `border: 1px solid transparent` in default and hover states so the button keeps consistent dimensions regardless of focus/active state, avoiding layout shift when hovering an active tertiary button.
Use nullish coalescing to safely handle optional $size prop when indexing CSS_SIZE_PROPERTIES, preventing "undefined cannot be used as an index type" compile error.
Duplicate import of pallete.ts in TextInput component.
This library is a thin wrapper for Material UI components in some cases. BBBModal and BBBToggle are two of those, but their underlying Material UI props are not exposed, limiting capabilities that consumers would otherwise get for free. Allow consumers to pass native and Material UI props directly to the underlying elements of BBBModal and BBBToggle.
The optional prop `tooltipLabel` is initialized with `null`, but its type only accepts `string` or `undefined`, causing a prop type error. Set the default value of `tooltipLabel` to `undefined` to match its type definition.
fix(BBButton): prevent size change on hover for tertiary variant when focused
feat: expose underlying element props for BBBModal and BBBToggle
Removes unused and wrong types file.
The props of BBBModal and BBBToggle has been changed recently to expose the props of the underlying Material UI components but the readme of such components has not been updated. So this commit does it.
- Add merge-branches composite action that checks out the base branch and merges the PR head into it before CI runs, catching integration issues early; includes error handling with annotated error messages on failure - Add ts-code-validation workflow: runs ESLint on pull requests against the merged result of base + PR branches - Add ts-code-compilation workflow: runs tsc type-check on pull requests against the merged result of base + PR branches - Add sync-develop workflow: opens a back-merge PR from main into develop on every version tag push; skips if develop doesn't exist, branches are already in sync, or a PR is already open
Update component's readme, add github actions workflows and pull request/issue templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.