Skip to content

refactor(catalyst-cli): use z.infer types in project.ts#3020

Open
parthshahp wants to merge 1 commit into
canaryfrom
zod-cli-deploy
Open

refactor(catalyst-cli): use z.infer types in project.ts#3020
parthshahp wants to merge 1 commit into
canaryfrom
zod-cli-deploy

Conversation

@parthshahp
Copy link
Copy Markdown
Contributor

Summary

Replaces manually-declared interface ProjectListItem and interface CreateProjectResult in packages/catalyst/src/cli/lib/project.ts with z.infer<typeof ...> derived from the existing zod schemas, matching the codebase convention. No behavior change — the schemas already validated the trust boundary; this just removes the duplicated type declarations so the types stay in sync with the schema.

Part of a broader sweep replacing manual type validation with zod across the monorepo.

Test plan

  • pnpm --filter ./packages/catalyst typecheck
  • pnpm --filter ./packages/catalyst build
  • pnpm --filter ./packages/catalyst test (44 tests)
  • pnpm --filter ./packages/catalyst lint

@parthshahp parthshahp requested a review from a team as a code owner May 19, 2026 22:04
@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
catalyst Ready Ready Preview, Comment May 19, 2026 10:04pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2026

⚠️ No Changeset found

Latest commit: c79c1f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

Unlighthouse Performance Comparison — Vercel

Comparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores.

Summary Score

Aggregate score across all categories as reported by Unlighthouse.

Prod Desktop Prod Mobile Preview Desktop Preview Mobile
Score 90 93 92 95

Category Scores

Category Prod Desktop Prod Mobile Preview Desktop Preview Mobile
Performance 72 91 77 84
Accessibility 95 92 95 92
Best Practices 100 100 100 100
SEO 88 100 100 100

Core Web Vitals

Metric Prod Desktop Prod Mobile Preview Desktop Preview Mobile
LCP 5.1 s 3.5 s 3.5 s 4.5 s
CLS 0.037 0 0.001 0
FCP 1.2 s 1.1 s 1.1 s 1.1 s
TBT 0 ms 0 ms 0 ms 10 ms
Max Potential FID 40 ms 50 ms 40 ms 80 ms
Time to Interactive 5.1 s 3.6 s 3.6 s 4.7 s

Full Unlighthouse report →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant