fix(loading-states): prevent triggering loading-states on preloaded requests#183
Open
adamjhf wants to merge 1 commit intobigskysoftware:mainfrom
Open
fix(loading-states): prevent triggering loading-states on preloaded requests#183adamjhf wants to merge 1 commit intobigskysoftware:mainfrom
adamjhf wants to merge 1 commit intobigskysoftware:mainfrom
Conversation
✅ Deploy Preview for htmx-extensions canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #182 by preventing loading-states triggering on preloaded requests.
Htmx version: 2.0.7
Used extension(s) version(s): loading-states 2.0.1, preload 2.1.1
Corresponding issue: #182
Testing
Tested manually by validating loading-data element not visible for preloaded request using example HTML below.
Added new test to validate loading-data
displayremainsnonewhen preloaded request is triggered.Checklist
npm run test) and verified that it succeeded