Skip to content

FIX: Emit "storey-selected" event instead of direct assignment #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kurtil merged 2 commits into from
Oct 15, 2025
Merged

FIX: Emit "storey-selected" event instead of direct assignment #27

Kurtil merged 2 commits into from
Oct 15, 2025

Conversation

@Kurtil
Copy link
Member

@Kurtil Kurtil commented Oct 15, 2025

This changes prevent storey change from js to trigger the event.
Because:

  • the StoreySelector component must react to the event to change the displayed selected storey (but not trigger the event)
  • trigger the event ONLY if the storey is changed from the UI.

@Kurtil Kurtil requested a review from NicolasRichel October 15, 2025 12:02
@Kurtil Kurtil self-assigned this Oct 15, 2025
@Kurtil Kurtil added the bug Something isn't working label Oct 15, 2025
@Kurtil Kurtil merged commit c1172cf into main Oct 15, 2025
1 check passed
@Kurtil Kurtil deleted the Fix/selectStoreyLogic branch October 15, 2025 12:11
github-actions bot pushed a commit that referenced this pull request Oct 15, 2025
@semantic-release-bot
chore(release): 1.7.11 [skip ci]
5ba6aea 
## [1.7.11](v1.7.10...v1.7.11) (2025-10-15)

### PATCH

* StoreySelector emits "storey-selected" event only from UI click (#27) ([c1172cf](c1172cf)), closes [#27](#27) [#28](#28)
@Bimdata-io
Copy link

Bimdata-io commented Oct 15, 2025

🎉 This PR is included in version 1.7.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasRichel NicolasRichel NicolasRichel approved these changes

Assignees

@Kurtil Kurtil

Labels

bug Something isn't working released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kurtil @Bimdata-io @NicolasRichel