Conversation
There seems to be a mypy issue that is only reported when using Python 3.13, which was used by the docker-tox target with current versions of the Docker image.
JGaukrogers
reviewed
Dec 10, 2024
JGaukrogers
reviewed
Dec 10, 2024
the-infinity
approved these changes
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of October this year, Python 3.8 is officially EOL.
In order to allow for more modern typing (e.g.
list[T]instead oftyping.List[T]), this PR removes support for Python 3.8 and modernizes the code to use features from Python 3.9. (Solves #15)This qualifies as a breaking change in terms of Python version compatibility. There are no breaking API changes, however.