-
Notifications
You must be signed in to change notification settings - Fork 19
Add pre-commit.ci config #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Should be merged after #739 |
|
So this is like a dependabot for pre commit? |
|
pre-commit CI is now disabled. I will enable it again, once this PR is merged and it does not fail anymore. |
Yes, it updates the pre-commit hooks like dependabot updates the GitHub Action versions. But crucially, it also runs the the pre-commit hooks in a CI, similar to They (https://pre-commit.ci/) claim it is faster than most CIs including GitHub Actions for this task due to targeted caching. |
|
Unfortunately, it seems like pre-commit.ci does not support cppcheck. For using clang-format, there is a different "officially" supported hook: https://github.com/pre-commit/mirrors-clang-format This leaves us with four options:
What do you think? |
Summary
Adds config for enabling https://pre-commit.ci/
This CI or rather GitHub-App runs the pre-commit hooks, pushes automatic fixes and regularly updates to the latest pre-commit hook versions
Proposed changes
Related issues
Checklist
just build