Skip to content

added get or add to the blackboard#436

Open
Clicky-coded wants to merge 1 commit intobitbrain:godot-4.xfrom
Clicky-coded:godot-4.x
Open

added get or add to the blackboard#436
Clicky-coded wants to merge 1 commit intobitbrain:godot-4.xfrom
Clicky-coded:godot-4.x

Conversation

@Clicky-coded
Copy link
Copy Markdown

This will close #435

@bitbrain
Copy link
Copy Markdown
Owner

@Clicky-coded could you extend the existing blackboard unit test to have a simple test for this?

Copy link
Copy Markdown
Owner

@bitbrain bitbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test required

@Clicky-coded
Copy link
Copy Markdown
Author

I dont think i will be able to write a unit test for some time as I do not know gdunit and am busy with other stuff

@bitbrain
Copy link
Copy Markdown
Owner

@Clicky-coded it's fairly easy, see https://github.com/bitbrain/beehave/blob/godot-4.x/test/blackboard/blackboard_test.gd basically just 4-5 lines where you call the method and verify it works.

Unfortunately, I cannot accept pull requests without test coverage, as beehave has very high quality standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get or add value function on Blackboard.

2 participants