Skip to content

bip-0085: add Go reference implementation#2156

Closed
satindergrewal wants to merge 1 commit into
bitcoin:masterfrom
satindergrewal:bip-0085-go
Closed

bip-0085: add Go reference implementation#2156
satindergrewal wants to merge 1 commit into
bitcoin:masterfrom
satindergrewal:bip-0085-go

Conversation

@satindergrewal
Copy link
Copy Markdown

Add shurlinet/go-bip85 to the BIP85 reference implementations list.

  • BIP85 v2.0.0 (includes DICE application)
  • All 12 spec test vectors pass byte-for-byte
  • 268 cross-implementation vectors generated from bipsea
  • Test patterns adopted from ethankosakovsky/bip85 (DRNG split reads, length edge cases)
  • RSA supported via DRNG workaround (Go 1.24+ FIPS 140-3 constraint)
  • MIT license
  • pkg.go.dev documentation

@satindergrewal
Copy link
Copy Markdown
Author

looks like Typo check failed due to HTTP 404 downloading typos v1.46.1 binary - CI infrastructure issue, not a typo in the change.

Comment thread bip-0085.mediawiki
* 1.3.0 Python 3.x library implementation: [https://github.com/akarve/bipsea]
* 1.1.0 Python 2.x library implementation: [https://github.com/ethankosakovsky/bip85]
* 1.0.0 JavaScript library implementation: [https://github.com/hoganri/bip85-js]
* 2.0.0 Go library implementation: [https://github.com/shurlinet/go-bip85]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not allow collecting additional implementations in BIPs.

Via BIP3:

“It is not intended for BIPs to list additional implementations beyond the reference implementation: the BIPs repository is not a signpost where to find implementations.”

The reasoning is given as follows:

In the past, some BIPs had "Other Implementations" sections that caused frequent change requests to existing BIPs. This put a burden on the BIP authors and BIP Editors, and frequently led to lingering pull requests due to the corresponding BIPs’ authors no longer participating in the process. Many of these alternative implementations eventually became unmaintained or were low-quality to begin with. Therefore, "Other Implementations" sections are heavily discouraged.

@murchandamus
Copy link
Copy Markdown
Member

murchandamus commented May 11, 2026

I’m closing this PR, because it is not intended to link to a collection of numerous implementations in a BIP. cc: @akarve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants