feat(chain): add walk_ancestors_from_root to TxGraph#2218
Open
Dmenec wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2218 +/- ##
==========================================
- Coverage 77.69% 77.55% -0.14%
==========================================
Files 29 29
Lines 5801 5811 +10
Branches 271 271
==========================================
Hits 4507 4507
- Misses 1223 1233 +10
Partials 71 71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #2216
Description
Add
walk_ancestors_from_rootmethod toTxGraph, which mirrors the existingwalk_ancestorsbut includes the root transaction in the iteration.Notes to the reviewers
An alternative implementation would have been to make TxAncestors::new_include_root public directly, instead of adding a wrapper method on TxGraph. Not sure which approach is preferable here.
Changelog notice
Added
TxGraph::walk_ancestors_from_rootChecklists
All Submissions:
New Features: