Skip to content

fix(ci): bump pinned webpki-roots to 1.0.5 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oleonardolima merged 5 commits into from
Jan 5, 2026
Merged

fix(ci): bump pinned webpki-roots to 1.0.5 #153

oleonardolima merged 5 commits into from
Jan 5, 2026

Conversation

@oleonardolima
Copy link
Collaborator

@oleonardolima oleonardolima commented Jan 4, 2026

I was about to merge #114, but there's been a new release (i.e v1.0.5) for webpki-roots which breaks our MSRV CI.

This PR updates its pinned version to fix our MSRV CI jobs, so we can move forward with #114.

@oleonardolima oleonardolima self-assigned this Jan 4, 2026
@oleonardolima oleonardolima added the ci Continuous Integration issues label Jan 4, 2026
@coveralls
Copy link

coveralls commented Jan 4, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 20702465376

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.654%
Totals Coverage Status
Change from base Build 20348214326: 0.0%
Covered Lines: 1387
Relevant Lines: 1530
💛 - Coveralls

@luisschwab
Copy link
Member

luisschwab commented Jan 4, 2026

@oleonardolima you need to pin more stuff

@oleonardolima oleonardolima mentioned this pull request Jan 5, 2026
Open
9 tasks
@oleonardolima
Copy link
Collaborator Author

oleonardolima commented Jan 5, 2026

@oleonardolima you need to pin more stuff

It's all fixed now.

luisschwab
luisschwab approved these changes Jan 5, 2026
View reviewed changes
Copy link
Member

@luisschwab luisschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 477cf8a

ValuedMammal
ValuedMammal approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 477cf8a

@oleonardolima oleonardolima merged commit 7c7b73a into bitcoindevkit:master Jan 5, 2026
26 checks passed
@oleonardolima oleonardolima deleted the ci/update-pinned-webpki-roots branch January 5, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ValuedMammal ValuedMammal ValuedMammal approved these changes

@notmandatory notmandatory Awaiting requested review from notmandatory

+1 more reviewer

@luisschwab luisschwab luisschwab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@oleonardolima oleonardolima

Labels

ci Continuous Integration issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oleonardolima @coveralls @luisschwab @ValuedMammal