Newsletters: add 387 (2026-01-09) #2603
Open
+153
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirijakes
reviewed
Jan 7, 2026
Comment on lines
+17
to
+19
| wallet that use an unnamed wallet.dat file and that had not previously | ||
| migrated their wallet to a descriptor wallet and who attempt a migration in | ||
| these versions could, if the migration failed, have their wallet directory |
Contributor
There was a problem hiding this comment.
Do these ‘that’, ‘that’, ’who’ all refer to the users? Or some to the wallet?
Suggested change
| wallet that use an unnamed wallet.dat file and that had not previously | |
| migrated their wallet to a descriptor wallet and who attempt a migration in | |
| these versions could, if the migration failed, have their wallet directory | |
| wallet who (1) use an unnamed wallet.dat file, (2) had not previously | |
| migrated their wallet to a descriptor wallet and (3) attempt a migration in | |
| these versions could, if the migration fails, have their wallet directory |
murchandamus
reviewed
Jan 7, 2026
| - **Bitcoin Core wallet migration vulnerability**: Bitcoin Core posted a | ||
| [notice][bitcoin core notice] of a vulnerability in the legacy wallet | ||
| migration feature in versions 30.0 and 30.1. Users of a Bitcoin Core legacy | ||
| wallet that use an unnamed wallet.dat file and that had not previously |
Collaborator
There was a problem hiding this comment.
This is a bit ambiguous. Not the wallet file, but the wallet is unnamed in this scenario. Specifically, it means that the wallet name is empty string: "", but the file name is always wallet.dat.
Suggested change
| wallet that use an unnamed wallet.dat file and that had not previously | |
| wallet that use an unnamed wallet and that had not previously |
Comment on lines
+21
to
+23
| attempt wallet migrations using the GUI or RPC until v30.2 is released. Users | ||
| for anything other than migrating a legacy wallet can continue to use these | ||
| Bitcoin Core versions as normal. |
Collaborator
There was a problem hiding this comment.
There seems to be something missing here:
Suggested change
| attempt wallet migrations using the GUI or RPC until v30.2 is released. Users | |
| for anything other than migrating a legacy wallet can continue to use these | |
| Bitcoin Core versions as normal. | |
| attempt wallet migrations using the GUI or RPC until v30.2 is released. Users [using the wallet] | |
| for anything other than migrating a legacy wallet can continue to use these | |
| Bitcoin Core versions as normal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.