Bitcore vault #4039
Bitcore vault #4039
Conversation
| * Override signTx to require vault access | ||
| */ | ||
| public async signTx(params: any): Promise<any> { | ||
| return this.withVaultAccess(params.passphrase, super.signTx.bind(this), params); |
There was a problem hiding this comment.
this one is interesting withVaultAccess unlocks using the passphrase. but the passphrase still needs to be sent via params?
There was a problem hiding this comment.
Good catch. Updated.
| if (!walletEntry) { | ||
| throw new Error(`Wallet not found: ${name}`); | ||
| } | ||
|
|
There was a problem hiding this comment.
consider privateKey null check
if (!this.privateKey) {
throw new Error('Private key not available - secure process not initialized or already cleaned up');
}
| }); | ||
|
|
||
| await this.sendMessage<void>('initialize', {}); | ||
| const publicKeyPem = await this.sendMessage<string>('getPublicKey', {}); |
There was a problem hiding this comment.
consider validating retrieved key
if (!publicKeyPem || typeof publicKeyPem !== 'string' || publicKeyPem.trim().length === 0) {
throw new Error('Invalid public key received from secure process');
}
There was a problem hiding this comment.
Good call. typeof publicKeyPem !== 'string' || !publicKey.trim().length is functionally similar - any other falsy value (including undefined) than "" wouldn't make it past the type check, and the trim().length takes care of "".
| if (!this.publicKey) throw new Error('Vault not initialized (missing public key)'); | ||
|
|
||
| const promptText = opts.prompt ?? 'Passphrase: '; | ||
| const maxBytes = Math.min(Math.max(opts.maxBytes ?? 256, 8), 4096); |
There was a problem hiding this comment.
RSA-2048 with OAEP padding and SHA-256 can encrypt a maximum of 190 bytes of data in a single operation. publicEncrypt on line 340 will throw for passphrases > 190 bytes. consider using 190 instead of 4096
| return total > 0; | ||
| } | ||
|
|
||
| public secureHeapAllocationCheck(): boolean { |
There was a problem hiding this comment.
seems like dead code? also the base alloc >= current alloc is contradicting currentAllocation >= this.secureHeapBaseAllocation found on ln 70
3 participants
No description provided.