fix(CommandPalette): re-highlight first item after debounced results render#76
Merged
Conversation
…render Port of nuxt/ui efd7b8ec. b24ui's CommandPalette already mirrors the upstream structure (filteredGroups/filteredItems/rootRef and highlightFirstItem from navigate/navigateBack); the only gap was the re-highlight after the debounced (refDebounced) results re-render. - import `watch, nextTick` - watch(filteredGroups) -> nextTick -> rootRef.value?.highlightFirstItem() Also maintain the sync ledger going forward (resolves the drift noted in the project assessment / #75): set .sync/nuxt-ui.json cursor to efd7b8ec, backfill `processed` for #68-#72, add .sync/log/<sha>.md for this port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live sync — next commit in queue
Upstream:
efd7b8ec— fix(CommandPalette): re-highlight first item after debounced results renderImmediate next commit after
007b136a(#72) in the oldest-first queue.What & why
b24ui's
CommandPalette.vuealready mirrors the upstream structure —filteredGroups,filteredItems,rootRef(useTemplateRef), androotRef.value?.highlightFirstItem()calls innavigate/navigateBack. The only gap was re-highlighting the first item after the debounced (refDebounced) results re-render. Applied the fix 1:1 with upstream:b24ui divergence: none — framework-level (reka-ui Listbox), no icon/color/
b24ui-prop adaptation. Not a breaking change.Ledger maintenance (resolves drift from #75 §1)
Now that ports advance per-commit, this PR also starts maintaining
.sync/:.sync/nuxt-ui.json:cursor→efd7b8ec,processedbackfilled for feat(InputMenu)!: renameautocompleteprop tomode#68–fix(components): constrain popper content to available viewport height #72..sync/log/efd7b8ec….md: decision record for this port.sync_enabledstaysfalse(automation Phase 2 / #67 not live yet).Validation (linux verify script; windows .ps1 below in chat)
dev:prepare· ✅eslint· ✅typecheckpnpm exec vitest run(no-u) 4886 passed | 6 skippedwatchis non-immediate, so it does not fire on initial mount.https://claude.ai/code/session_01Qz7EXMncvEGiCj4WbmYgJo
Generated by Claude Code