You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks @ailuntz.
A few things need adjustment: First, the override should be a fallback after rocminfo fails, not a priority override that runs before it; for most users, auto-detection is more reliable and shouldn't be bypassed. Second, use only BNB_ROCM_GPU_ARCH and drop BNB_ROCM_ARCH, that name is already used as a CMake build-time variable and reusing it at runtime with different semantics is confusing. Third, add some basic validation on the value (e.g. check it matches gfx[a-zA-Z0-9]+) so garbage input doesn't silently propagate. And finally, the existing error message should mention BNB_ROCM_GPU_ARCH as a workaround so users know what to do when rocminfo fails (ask users to install rocminfo, if it's not possible then ask them to set the env variable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1444.\n\nSupport BNB_ROCM_GPU_ARCH override when rocminfo is unavailable.