allow lookup when there is already a popup

[gmachine1]

No longer need to first click to close popup before looking up another word. Tested locally on browser thru webpage https://en.wikipedia.org/wiki/Disquisitiones_Arithmeticae.

[bitsauce]

Hi there @gmachine1! Funny that someone found this repo/extension after all these years 🙂

These changes look pretty good! Although, I will need more time to give a proper review if that's desirable. But some immediate thoughts regarding these changes:

1. Is there a way to get a more complete list of languages to show in the options?
2. While I do agree that one shouldn't need to have to left-click to look up another word, the extension will need to be able to detect the difference between pressing and releasing <CRTL> + <SHIFT> vs holding <CRTL> + <SHIFT> to prevent dict lookup spam when holding down these buttons

Thanks for the effort!

• Marcus

[gmachine1]

Hi there @gmachine1! Funny that someone found this repo/extension after all these years 🙂

These changes look pretty good! Although, I will need more time to give a proper review if that's desirable. But some immediate thoughts regarding these changes:

1. Is there a way to get a more complete list of languages to show in the options?
2. While I do agree that one shouldn't need to have to left-click to look up another word, the extension will need to be able to detect the difference between pressing and releasing <CRTL> + <SHIFT> vs holding <CRTL> + <SHIFT> to prevent dict lookup spam when holding down these buttons

Thanks for the effort!

• Marcus

1. As for more complete list, let's start with Arabic, Chinese, English, French, Hebrew, German, Italian, Korean, Spanish. How's that? You are also welcome to propose more languages not already included.
2. I just tried on my browser holding down <CTRL>+<SHIFT> and it works fine. In the case of an existing popup the code closes it before opening another.