Skip to content

PM-38610: Bug: Update BitwardenBasicDialog to allow scrolling content#7028

Open
david-livefront wants to merge 1 commit into
mainfrom
PM-38610-scrollable-basic-dialog
Open

PM-38610: Bug: Update BitwardenBasicDialog to allow scrolling content#7028
david-livefront wants to merge 1 commit into
mainfrom
PM-38610-scrollable-basic-dialog

Conversation

@david-livefront
Copy link
Copy Markdown
Collaborator

@david-livefront david-livefront commented Jun 5, 2026

🎟️ Tracking

PM-38610

📔 Objective

This PR updates the BitwardenBasicDialog to be more like the BitwardenTwoButtonDialog in order to support scrolling content.

📸 Screenshots

Before After
Screen_recording_20260605_155645.mp4

@david-livefront david-livefront requested a review from a team as a code owner June 5, 2026 20:58
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:bug Change Type - Bug labels Jun 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the refactor of BitwardenBasicDialog from AlertDialog to a custom Dialog-based layout that mirrors BitwardenTwoButtonDialog to support scrolling content. The public function signature is unchanged, all existing test tags (AlertPopup, AlertTitleText, AlertContentText, AcceptAlertButton, ShareErrorDetailsAlertButton) are preserved, and the implementation correctly reuses the shared maxDialogHeight/maxDialogWidth extensions and BitwardenHorizontalDivider indicator pattern. No call-site updates are required across the ~50 consumers.

Code Review Details

No findings.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.10%. Comparing base (c0caaf9) to head (79052eb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7028      +/-   ##
==========================================
+ Coverage   85.50%   87.10%   +1.59%     
==========================================
  Files        1005      859     -146     
  Lines       66462    63474    -2988     
  Branches     9328     9260      -68     
==========================================
- Hits        56829    55287    -1542     
+ Misses       6426     4994    -1432     
+ Partials     3207     3193      -14     
Flag Coverage Δ
app-data 17.42% <ø> (+0.30%) ⬆️
app-ui-auth-tools 19.00% <ø> (+<0.01%) ⬆️
app-ui-platform 16.43% <ø> (-0.38%) ⬇️
app-ui-vault 27.78% <ø> (-0.54%) ⬇️
authenticator 6.24% <ø> (+0.02%) ⬆️
lib-core-network-bridge 4.09% <ø> (+0.02%) ⬆️
lib-data-ui 1.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant