-
Notifications
You must be signed in to change notification settings - Fork 21
Remove server bindings docs #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying contributing-docs with ย
|
| Latest commit: |
d2030ab
|
| Status: | ย โ ย Deploy successful! |
| Preview URL: | https://50be240f.contributing-docs.pages.dev |
| Branch Preview URL: | https://remove-server-bindings-docs.contributing-docs.pages.dev |
|
Great job! No new security vulnerabilities introduced in this pull request |
withinfocus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to do an org-wide search for any references to the now-deleted page before you merge.
@withinfocus I confirmed the only usages were here and in the archived https://github.com/bitwarden/developers. |
## ๐ Objective Adds documentation to the root README to describe how to consume and update API bindings. Includes changes from #622 in which @harr1424 identified issues with our local binding generation instructions as well. Despite this not being the preferred way to update bindings, it's important for those instructions to be accurate as well. Corresponding PR for removing the docs from Contributing Docs: bitwarden/contributing-docs#735. Related PR for adding more documentation to `bitwarden-core`: #618. ## ๐จ Breaking Changes <!-- Does this PR introduce any breaking changes? If so, please describe the impact and migration path for clients. If you're unsure, the automated TypeScript compatibility check will run when you open/update this PR and provide feedback. For breaking changes: 1. Describe what changed in the client interface 2. Explain why the change was necessary 3. Provide migration steps for client developers 4. Link to any paired client PRs if needed Otherwise, you can remove this section. --> ## โฐ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## ๐ฆฎ Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - ๐ (`:+1:`) or similar for great changes - ๐ (`:memo:`) or โน๏ธ (`:information_source:`) for notes or general info - โ (`:question:`) for questions - ๐ค (`:thinking:`) or ๐ญ (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - ๐จ (`:art:`) for suggestions / improvements - โ (`:x:`) orโ ๏ธ (`:warning:`) for more significant problems or concerns needing attention - ๐ฑ (`:seedling:`) or โป๏ธ (`:recycle:`) for future improvements or indications of technical debt - โ (`:pick:`) for minor or nitpick changes --------- Co-authored-by: John Harrington <84741727+harr1424@users.noreply.github.com>

๐ Objective
Removes the Server Bindings docs from Contributing Docs. They will be added to
bitwarden-coreREADMEin bitwarden/sdk-internal#638.โฐ Reminders before review
team
๐ฆฎ Reviewer guidelines
:+1:) or similar for great changes:memo:) or โน๏ธ (:information_source:) for notes or general info:question:) for questions:thinking:) or ๐ญ (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or โป๏ธ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes