Skip to content

Conversation

@trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Dec 18, 2025

๐Ÿ“” Objective

Removes the Server Bindings docs from Contributing Docs. They will be added to bitwarden-core README in bitwarden/sdk-internal#638.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Remove server bindings docs. Remove server bindings docs Dec 18, 2025
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 18, 2025

Deploying contributing-docs with ย Cloudflare Pages ย Cloudflare Pages

Latest commit: d2030ab
Status:ย โœ…ย  Deploy successful!
Preview URL: https://50be240f.contributing-docs.pages.dev
Branch Preview URL: https://remove-server-bindings-docs.contributing-docs.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 5eb3e011-5129-4310-897b-647326cb3286

Great job! No new security vulnerabilities introduced in this pull request

@trmartin4 trmartin4 marked this pull request as ready for review December 30, 2025 02:59
@trmartin4 trmartin4 requested a review from a team as a code owner December 30, 2025 02:59
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to do an org-wide search for any references to the now-deleted page before you merge.

@trmartin4
Copy link
Member Author

Might want to do an org-wide search for any references to the now-deleted page before you merge.

@withinfocus I confirmed the only usages were here and in the archived https://github.com/bitwarden/developers.

@trmartin4 trmartin4 merged commit 0582315 into main Dec 30, 2025
19 checks passed
@trmartin4 trmartin4 deleted the remove-server-bindings-docs branch December 30, 2025 18:20
trmartin4 added a commit to bitwarden/sdk-internal that referenced this pull request Dec 30, 2025
## ๐Ÿ“” Objective

Adds documentation to the root README to describe how to consume and
update API bindings.

Includes changes from #622 in which @harr1424 identified issues with our
local binding generation instructions as well. Despite this not being
the preferred way to update bindings, it's important for those
instructions to be accurate as well.

Corresponding PR for removing the docs from Contributing Docs:
bitwarden/contributing-docs#735.

Related PR for adding more documentation to `bitwarden-core`:
#618.

## ๐Ÿšจ Breaking Changes

<!-- Does this PR introduce any breaking changes? If so, please describe
the impact and migration path for clients.

If you're unsure, the automated TypeScript compatibility check will run
when you open/update this PR and provide feedback.

For breaking changes:
1. Describe what changed in the client interface
2. Explain why the change was necessary
3. Provide migration steps for client developers
4. Link to any paired client PRs if needed

Otherwise, you can remove this section. -->

## โฐ Reminders before review

- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or
informed the documentation
  team

## ๐Ÿฆฎ Reviewer guidelines

<!-- Suggested interactions but feel free to use (or not) as you desire!
-->

- ๐Ÿ‘ (`:+1:`) or similar for great changes
- ๐Ÿ“ (`:memo:`) or โ„น๏ธ (`:information_source:`) for notes or general info
- โ“ (`:question:`) for questions
- ๐Ÿค” (`:thinking:`) or ๐Ÿ’ญ (`:thought_balloon:`) for more open inquiry
that's not quite a confirmed
  issue and could potentially benefit from discussion
- ๐ŸŽจ (`:art:`) for suggestions / improvements
- โŒ (`:x:`) or โš ๏ธ (`:warning:`) for more significant problems or
concerns needing attention
- ๐ŸŒฑ (`:seedling:`) or โ™ป๏ธ (`:recycle:`) for future improvements or
indications of technical debt
- โ› (`:pick:`) for minor or nitpick changes

---------

Co-authored-by: John Harrington <84741727+harr1424@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants