[PM-30483] Remove feature flagged logic around passkey unlock#7318
[PM-30483] Remove feature flagged logic around passkey unlock#7318
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7318 +/- ##
==========================================
+ Coverage 57.86% 57.87% +0.01%
==========================================
Files 2044 2044
Lines 90081 90112 +31
Branches 8014 8014
==========================================
+ Hits 52126 52156 +30
- Misses 36091 36092 +1
Partials 1864 1864 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eligrubb
added
the
ai-review-vnext
eligrubb
removed
the
ai-review-vnext
| var organizationIdsClaimingActiveUser = organizationClaimingActiveUser.Select(o => o.Id); | ||
|
|
||
| var organizationAbilities = await GetOrganizationAbilitiesAsync(ciphers); | ||
| var webAuthnCredentials = _featureService.IsEnabled(FeatureFlagKeys.PM2035PasskeyUnlock) |
There was a problem hiding this comment.
❓ do we also need to remove PM2035PasskeyUnlock from the constants.cs
There was a problem hiding this comment.
I believe we need to leave the flag in constants.cs. The server still needs to report the feature flag for 3 releases after we remove it from clients to maintain backwards compatibility; the flagged logic is part of the extension client. There is a separate ticket, PM-30484, for removing the flag completely.
2 participants
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-30483
📔 Objective
Now that passkey unlock has been released, this change, paired with clients PR#19798 removes the logic related to the passkey unlock feature flag
pm-2035-passkey-unlock. The feature flag itself will be removed in a future ticket: https://bitwarden.atlassian.net/browse/PM-30484📸 Screenshots