[PM-34134] [Innovation] Implement UserPreferences table and add to sync response#7329
Merged
gbubemismith merged 19 commits intoinnovation/sync-user-preferencesfrom Apr 1, 2026
Conversation
Introduces the UserPreferences domain entity, repository interface, and Dapper implementation for storing user synced preferences.
…user-preferences-PM-34134
gbubemismith
requested review from
nick-livefront and
shane-melton
and removed request for
a team
gbubemismith
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## innovation/sync-user-preferences #7329 +/- ##
===================================================================
Coverage ? 62.15%
===================================================================
Files ? 2059
Lines ? 90582
Branches ? 8053
===================================================================
Hits ? 56304
Misses ? 32322
Partials ? 1956 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
New Issues (140)Checkmarx found the following issues in this Pull Request
|
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
util/MySqlMigrations/Migrations/20260326201149_UserPreferencesInit.cs
Outdated
Show resolved
Hide resolved
| userAccountKeys = await _userAccountKeysQuery.Run(user); | ||
| } | ||
|
|
||
| var userPreferences = await _userPreferencesRepository.GetByUserIdAsync(user.Id); |
Contributor
There was a problem hiding this comment.
Details and fix
The UserPreferencesController is gated behind [RequireFeature(FeatureFlagKeys.SyncUserPreferences)], but this sync endpoint unconditionally queries the UserPreferences table for every user on every sync call. This adds an extra DB round-trip to one of the most frequently called endpoints, even when the feature is disabled and no users have preferences.
This controller already establishes the pattern of gating behind feature flags before querying -- see webAuthnCredentials on line 131:
var webAuthnCredentials = _featureService.IsEnabled(FeatureFlagKeys.PM2035PasskeyUnlock)
? await _webAuthnCredentialRepository.GetManyByUserIdAsync(user.Id)
: [];Suggested fix:
Suggested change
| var userPreferences = await _userPreferencesRepository.GetByUserIdAsync(user.Id); | |
| var userPreferences = _featureService.IsEnabled(FeatureFlagKeys.SyncUserPreferences) | |
| ? await _userPreferencesRepository.GetByUserIdAsync(user.Id) | |
| : null; |
Member
There was a problem hiding this comment.
@gbubemismith We should probably gate the query behind the flag in the sync controller as suggested.
Contributor
Author
There was a problem hiding this comment.
oh I missed this
shane-melton
approved these changes
Mar 31, 2026
Member
shane-melton
left a comment
shane-melton
left a comment
There was a problem hiding this comment.
Looks great! Only suggestion would be to feature flag the sync controller, but since this is going to a feature branch first anyways, doesn't need to hold it up.
|
gbubemismith
merged commit 1921a7e
into
innovation/sync-user-preferences
50 of 51 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34134
📔 Objective
📸 Screenshots