[PM-31671] Add SSRF protections to ChangePasswordUriSErvice#7332
Open
[PM-31671] Add SSRF protections to ChangePasswordUriSErvice#7332
Conversation
|
Contributor
|
New Issues (2)Checkmarx found the following issues in this Pull Request
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7332 +/- ##
==========================================
+ Coverage 57.91% 58.02% +0.11%
==========================================
Files 2044 2049 +5
Lines 90130 90408 +278
Branches 8018 8036 +18
==========================================
+ Hits 52199 52460 +261
- Misses 36066 36082 +16
- Partials 1865 1866 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-31671
📔 Objective
This prevents the service that retrieves the change password URL from exposing internal details, by verifying that the domain does not resolve to an internal IP address. It uses the same approach as the Icons service in following redirects to ensure they are not internal-only services.
Note: When testing locally, all URLs are passing through
127.0.0.1due to a local proxy - I had to addUseProxy=falseto theHttpClientHandlerconstructor onSErviceCollectionExtension.cs:48. I suspect this is something configured in my localhost dev environment, since the existing IconsService uses this same approach without issue.