Auth/poc/master password service example#7349
Draft
Patrick-Pimentel-Bitwarden wants to merge 29 commits intomainfrom
Draft
Auth/poc/master password service example#7349Patrick-Pimentel-Bitwarden wants to merge 29 commits intomainfrom
Patrick-Pimentel-Bitwarden wants to merge 29 commits intomainfrom
Conversation
Contributor
|
New Issues (2)Checkmarx found the following issues in this Pull Request
Fixed Issues (5)Great job! The following issues were fixed in this Pull Request
|
… Tests are broken but getting closer to the ideal setup.
…ice now does it's own password validation.
…to use the unlock and authentication data. Also added in a new master password function to build the transaction for set password
…s around set data and updating occurences to use the master password service.
… around the request models and tightening them up to all be shaped similarly
… updated the changekdf function to use the master password service.
…request models and the master password service.
…rvice password change.
…df and account recovery tests.
…assword to use it's own standalone request and added commment for other function.
…roller to check password while changing.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7349 +/- ##
==========================================
+ Coverage 58.71% 63.10% +4.39%
==========================================
Files 2069 2079 +10
Lines 91207 91866 +659
Branches 8123 8211 +88
==========================================
+ Hits 53551 57975 +4424
+ Misses 35742 31862 -3880
- Partials 1914 2029 +115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| [HttpPost("kdf")] | ||
| public async Task PostKdf([FromBody] PasswordRequestModel model) | ||
| public async Task PostKdf([FromBody] ChangeKdfRequestModel model) |
Contributor
Author
There was a problem hiding this comment.
Need to double check if this will break anything with the sdk
… working on adding in the self service password change command.
…e password change command
…specific command to do the correct validation
…across a few domains.
…d and took in feedback from team member
…idation in command
… handing off to Dave. Mostly comments if not all comments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
📸 Screenshots