chore(penpal): add build/CI parity with mark and staged#301
Draft
chore(penpal): add build/CI parity with mark and staged#301
Conversation
loganj
changed the title
Collaborator
Author
|
@codex review Comment posted automatically by outer-loop |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0eafeb14b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
loganj
force-pushed
the
fix/cargo-exclude-penpal
branch
2 times, most recently
from
735a84d to
aee9725
Compare
The penpal app's src-tauri crate has its own workspace and should not be discovered by the root workspace, matching the pattern used by mark and staged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add penpal-ci.yml GitHub Actions workflow matching mark/staged pattern - Add fmt, fmt-check, lint, typecheck, and ci recipes to justfile - The root justfile's check/lint/fmt loops now discover and run penpal checks Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add apps/penpal/frontend to pnpm-workspace.yaml - Delete package-lock.json in favor of root pnpm-lock.yaml - Update justfile and CI to use pnpm instead of npm - Drop unconfigured eslint from fmt/fmt-check (no eslint.config.js exists) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Go: relax TestAPIProjects_ListsProjects to assert >= 2 projects (flaky due to host environment discovery) - TS: remove unused imports (fireEvent, vi) and unused variable - TS: fix CommentsPanel test passing extra fields to narrower prop type Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit 491f689.
loganj
force-pushed
the
fix/cargo-exclude-penpal
branch
from
aee9725 to
5d0f8e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings penpal's build integration to parity with mark and staged:
apps/penpal/frontend/src-taurito the rootCargo.tomlexclude list, matching the pattern used by mark and stagedpenpal-ci.ymlGitHub Actions workflow (fmt-check, lint, typecheck, test) matching the mark/staged patternfmt,fmt-check,lint,typecheck, andcirecipes so the root justfile'scheck/lint/fmtloops now discover and run penpal checks🤖 Generated with Claude Code