Skip to content

fix: update hermit to public distribution and CODEOWNERS for OSS #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
worstell wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

fix: update hermit to public distribution and CODEOWNERS for OSS #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @squareup/local-dev
* @alecthomas @boblail @jrobotham-square @mpeyper @nssherpa @preetim-cash @stuartwdouglas @worstell @wsutina
4 changes: 2 additions & 2 deletions bin/hermit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ if [ -z "${HERMIT_STATE_DIR}" ]; then
esac
fi

export HERMIT_DIST_URL="${HERMIT_DIST_URL:-https://d1abdrezunyhdp.cloudfront.net/square}"
export HERMIT_DIST_URL="${HERMIT_DIST_URL:-https://github.com/cashapp/hermit/releases/download/stable}"
HERMIT_CHANNEL="$(basename "${HERMIT_DIST_URL}")"
export HERMIT_CHANNEL
export HERMIT_EXE=${HERMIT_EXE:-${HERMIT_STATE_DIR}/pkg/hermit@${HERMIT_CHANNEL}/hermit}
Expand All @@ -26,7 +26,7 @@ if [ ! -x "${HERMIT_EXE}" ]; then
echo "Bootstrapping ${HERMIT_EXE} from ${HERMIT_DIST_URL}" 1>&2
INSTALL_SCRIPT="$(mktemp)"
# This value must match that of the install script
INSTALL_SCRIPT_SHA256="4b006236f2e5e81939229b377bb355e3608f94d73ff8feccbd5792d1ed5699cd"
INSTALL_SCRIPT_SHA256="09ed936378857886fd4a7a4878c0f0c7e3d839883f39ca8b4f2f242e3126e1c6"
if [ "${INSTALL_SCRIPT_SHA256}" = "BYPASS" ]; then
curl -fsSL "${HERMIT_DIST_URL}/install.sh" -o "${INSTALL_SCRIPT}"
else
Expand Down
3 changes: 1 addition & 2 deletions bin/hermit.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
github-token-auth {
}

1 change: 1 addition & 0 deletions src/backend/go.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ impl Backend for GoBackend {
.unwrap_or_else(|| repo_root.to_path_buf());
packages.insert(dir);
} else if file.extension().is_some_and(|ext| ext == "go") {
#[allow(clippy::collapsible_if)]
if let Some(parent) = file.parent() {
let dir = repo_root.join(parent);
if dir.exists() {
Expand Down